On 13.12.2008 22:39, Pattrick Hueper wrote: > On Sat, Dec 13, 2008 at 10:18 PM, Myles Watson <[email protected]> wrote: > >> >> Can you sign it off as per the guidelines at >> >> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure >> >> > > All the patches already contain a Signed-off-by line. Is that sufficient? >
Yes, of course. However, your thread starter mail didn't contain any Signed-off-by line and I didn't check the git log. That was probably the source of the misunderstanding. I added the git log for reference. commit b2d0ed51897b74c5a3cbc0a0c380b9624e7ebf61 Author: Pattrick Hueper <[email protected]> Date: Thu Dec 4 23:50:08 2008 +0100 replace all uintXX_t intXX_t in biosemu code Signed-off-by: Pattrick Hueper <[email protected]> commit 6fd47b4d8cc2b4d7ff1bcc7bf359809c4bd5576a Author: Pattrick Hueper <[email protected]> Date: Tue Dec 2 22:11:17 2008 +0100 enable debug (-g) Signed-off-by: Pattrick Hueper <[email protected]> commit 737b6a40467241bf863908be526c7817c6c07c86 Author: Pattrick Hueper <[email protected]> Date: Thu Nov 27 15:30:06 2008 +0100 disable DEBUG Signed-off-by: Pattrick Hueper <[email protected]> commit 0064fc1585e1a1d218b97c5dd59cf3488d992a38 Author: Pattrick Hueper <[email protected]> Date: Thu Nov 27 12:58:48 2008 +0100 it woiks, it woiks.... Signed-off-by: Pattrick Hueper <[email protected]> commit 282e1a4d374e3a16c2f1ec522117ffe2ae403407 Author: Pattrick Hueper <[email protected]> Date: Thu Nov 27 10:24:11 2008 +0100 merge SLOF-JX-1.7.0-4 updates Signed-off-by: Pattrick Hueper <[email protected]> commit 59c1609030ba3b4fe5fd70400841c0c3ecba4395 Author: Pattrick Hueper <[email protected]> Date: Thu Nov 27 10:06:37 2008 +0100 yipieeh... it builds... and starts... doesnt work yet, though :-( Signed-off-by: Pattrick Hueper <[email protected]> commit 2957f93794f3f039bbeac3a277fdcd44d76284ae Author: Pattrick Hueper <[email protected]> Date: Mon Nov 24 22:48:06 2008 +0100 biosemu needs libgcc... just as x86emu does Signed-off-by: Pattrick Hueper <[email protected]> commit 151d21c17555fcf87c235efb93ae98bd59d09ecf Author: Pattrick Hueper <[email protected]> Date: Mon Nov 24 22:01:46 2008 +0100 fix build warnings in x86emu, especially with -DDEBUG Signed-off-by: Pattrick Hueper <[email protected]> commit 2f1acf88bbd7d3fc9535357c5282fe807d5a5b12 Author: Pattrick Hueper <[email protected]> Date: Mon Nov 24 21:46:24 2008 +0100 x86emu changes from slof-JX-1.0.7-4 implemented bswap opcodes, some tracing fixes, small bugfixes Signed-off-by: Pattrick Hueper <[email protected]> commit 9644fedf2dbbb2b3bcd4331758bc2e6a335ee8af Author: Pattrick Hueper <[email protected]> Date: Mon Nov 24 12:17:54 2008 +0100 x86emu changes and fixes from slof Signed-off-by: Pattrick Hueper <[email protected]> commit 94fe38a7b6d5ca7965c60e053afa4baef16744cc Author: Pattrick Hueper <[email protected]> Date: Sun Nov 23 11:40:21 2008 +0100 build integration of biosemu Signed-off-by: Pattrick Hueper <[email protected]> commit 0aab2795a986e76286386ebd02e59ca75a528538 Author: Pattrick Hueper <[email protected]> Date: Sun Nov 23 11:04:32 2008 +0100 original biosemu version, copied from slof-JX-1.7.0-1 Signed-off-by: Pattrick Hueper <[email protected]> commit 0b61af8d4829535e6d90fee26c0e7d0aec09435d Author: Pattrick Hueper <[email protected]> Date: Sat Nov 22 22:40:59 2008 +0100 add .gitignore Signed-off-by: Pattrick Hueper <[email protected]> >> and change any code where you'd like it to be YABEL? Then I'll Ack and >> commit it. >> >> > > Hm, would you like me to move it from the biosemu directory to a yabel > directory? > Otherwise i would just leave it as it is and refer to it as YABEL in > the mails... I would like to keep the code close to the SLOF source > code, since i would like to have fixes/enhancement in both > repositories... > The biosemu directory sounds fine. There's one thing we have to decide on, though. Should all of this be committed as one big block or is a split into multiple patches preferable? I'd like at least one commit which mirrors the YABEL part of the SLOF tree (commit 0aab2795a986e76286386ebd02e59ca75a528538). Later changes can be grouped, but it never huts to have a reference point available, especially if there is a chance that the YABEL codebase may get some fixes in SLOF. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
