On 13.11.2008 01:18, Mart Raudsepp wrote: > Return the count of failures from ram_check. > > Will be necessary for DBE61 automatic memory size selection. > > Signed-off-by: Mart Raudsepp <[EMAIL PROTECTED]> >
We really want __attribute__((warn_unused_result)) for ram_check. Besides that, lib/ramtest.c could use some cleanups. ram_read_phys() and ram_write_phys() are nothing but really complicated versions of readl() and writel(). It would be cool if you could tackle that in another patch. Anyway, this patch improves the current situation, so it is Acked-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]> Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
