Carl-Daniel Hailfinger wrote:
On 17.07.2008 00:06, Marc Jones wrote:
Some HT cleanup. Shouldn't be anything major.
Clean up AMD FAM10 HT variable initialization. The structure init is cleaner,
avoid compiler warnings,
and matches the AMD example code more closely.
Signed-off-by: Marc Jones <[EMAIL PROTECTED]>
While I do like most parts of the cleanup, I'm not so totally sure about
the structure inits. They are easier to read now, but I wonder whether
C99 initializers would have been the way to go.
Regards,
Carl-Daniel
The example code that this is based on has to build with a pre-c99
compiler. c99 initializers would have been the way to go if that were
not the case. I wouldn't nack a change but it does make it easier to
track changes if the code stays similar.
Marc
--
Marc Jones
Senior Firmware Engineer
(970) 226-9684 Office
mailto:[EMAIL PROTECTED]
http://www.amd.com/embeddedprocessors
--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
