On Thu, 2 Oct 2025 03:08:32 GMT, Shaojin Wen <[email protected]> wrote:
>> I propose to make j.t.f.DateTimePrintContext immutable. >> >> Currently, DateTimePrintContext has only one mutable field, optional. This >> can be replaced by adding an optional parameter to the >> DateTimeFormatter.formatTo method. >> >> Immutable DateTimePrintContext can be optimized by escape analysis, such as >> immutable object optimization. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > Improve javadoc for optional parameter in DateTimePrinterParser#format > method I think this is a good change. This allows DateTimePrintContext to be refactored to a value class later, which may unlock more optimization opportunities. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26913#pullrequestreview-3385723601
