On Thu, 23 Oct 2025 14:15:03 GMT, Viktor Klang <[email protected]> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 15 additional >> commits since the last revision: >> >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8367857 >> - Merge branch 'master' into JDK-8367857 >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8367857 >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8367857 >> - Merge branch 'master' into JDK-8367857 >> - Improve docs and review feedback >> - Merge branch 'master' into JDK-8367857 >> - ... and 5 more: https://git.openjdk.org/jdk/compare/9c45d6d9...28617cff > > src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java > line 334: > >> 332: * #fork forking} of a subtask {@linkplain >> java.util.concurrent##MemoryVisibility >> 333: * <i>happen-before</i>} any actions taken by that subtask, which in >> turn >> 334: * <i>happen-before</i> the subtask result is {@linkplain Subtask#get() >> retrieved}. > > This may be interpreted as users calling result() so it might be worth > clarifying it as: > > "<i>happen-before</i> the subtask result is {@linkplain Subtask#get() > retrieved} by {@linkplain #join() join()} The only change here is using the "##" in the link. So this is pre-existing wording (not changed in this update). I agree it could be mis-read and okay to change it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27392#discussion_r2455861278
