On Fri, 3 Oct 2025 05:41:58 GMT, Jaikiran Pai <[email protected]> wrote:

>> Update SimpleHttpServer class to use SimpleFileServer.
>
> Interestingly, there's even a 
> `test/jdk/com/sun/net/httpserver/SimpleFileServer.java` class which is 
> neither a test nor a test library class. As far as I can see, it's not being 
> used anywhere. Maybe we should remove that one too. These similarly named 
> classes add to confusion.

> The SimpleHttpServer class that Mahendra is updating is used by multi-relase 
> jars and jaxp catalog tests. It could be prudent to update the class first, 
> check that everything remains stable, and then replace usage in a followup 
> issue. It seems this class is only being used by three tests however - so 
> maybe updating those three tests to use the SimpleFileServer directly won't 
> be too bad. If we do that then make sure we keep the same behaviour = keep 
> the executor as @jaikiran suggested.
> 
> Good find about `test/jdk/com/sun/net/httpserver/SimpleFileServer.java` - 
> let's attempt to remove it - it does not appear to be used anywhere.

Thanks, Now test/jdk/com/sun/net/httpserver/SimpleFileServer.java is removed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27608#issuecomment-3366628509

Reply via email to