> The teardown of a Process launched by `ProcessBuilder` includes the closing 
> of streams and ensuring the termination of the process is the responsibility 
> of the caller. The `Process.close()` method provides a clear and obvious way 
> to ensure all the streams are closed and the process terminated.
> 
> The try-with-resources statement is frequently used to open streams and 
> ensure they are closed on exiting the block. By implementing 
> `AutoClosable.close()` the completeness of closing the streams and process 
> termination can be done by try-with-resources.
> 
> The actions of the `close()` method are to close each stream and destroy the 
> process if it has not terminated.

Roger Riggs has updated the pull request incrementally with one additional 
commit since the last revision:

  Additional review feedback.
  Updated to emphasize reading the data from the streams and calling waitFor
  to allow for normal termination.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26649/files
  - new: https://git.openjdk.org/jdk/pull/26649/files/5a0c5602..aadb11db

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26649&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26649&range=11-12

  Stats: 16 lines in 2 files changed: 6 ins; 1 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/26649.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26649/head:pull/26649

PR: https://git.openjdk.org/jdk/pull/26649

Reply via email to