On Fri, 19 Sep 2025 18:35:36 GMT, Ashutosh Mehra <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed 32-bit builds
>
> src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 184:
>
>> 182:
>> 183: void AOTLinkedClassBulkLoader::link_or_init_javabase_classes(TRAPS) {
>> 184: link_or_init_classes_for_loader(Handle(),
>> AOTLinkedClassTable::get()->boot1(), CHECK);
>
> Is exception check not needed here, like it is done in
> `link_or_init_non_javabase_classes()`?
I changed this function to do the same check as in
`link_or_init_non_javabase_classes()`. I also updated the comments to explain
why this is necessary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26375#discussion_r2364925599
