On Tue, 8 Jul 2025 01:13:20 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8351073: [macos] jpackage produces invalid Java runtime DMG bundles [v2]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPackagingPipeline.java
> line 311:
>
>> 309: }
>> 310:
>> 311: private static void sign(AppImageBuildEnv<MacApplication,
>> MacApplicationLayout> env) throws IOException {
>
> I don't understand why individual signing functions are needed for the
> runtime and application bundles. They look identical to me.
One is used by `appImageAction` and second by `packageAction`. Maybe I am
misusing appImageAction and packageAction. These two actions requires
different argument `AppImageBuildEnv` vs `PackageBuildEnv`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26173#discussion_r2193714647
