On Wed, 7 May 2025 12:57:13 GMT, Chen Liang <li...@openjdk.org> wrote:
>> test/micro/org/openjdk/bench/java/math/BigIntegerPow.java line 72:
>>
>>> 70:
>>> 71: new Runner(opt).run();
>>> 72: }
>>
>> There's no need for these lines.
>
> These are here for convenience when a benchmark is run standalone. I think
> this has no harm.
There's no harm, but no need either.
We can add a comment like so, to clarify that the benchmark is here to measure
memory allocations, rather than running time.
You can run this test via the command line:
$ make test TEST="micro:java.math.BigIntegerPow" MICRO="OPTIONS=-prof gc"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24690#discussion_r2077590224
