On Mon, 24 Mar 2025 01:00:34 GMT, Chen Liang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - improve code comment for ZipFile.zipCoder
>> - Alan's suggestion - change code comment about Source class being thread
>> safe
>> - Alan's suggestion - trim the javadoc of (internal) ZipCoder class
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1145:
>
>> 1143: static record EntryPos(String name, int pos) {}
>> 1144:
>> 1145: // Implementation note: This class is be thread safe.
>
> Should we comment that this class has no observable state in addition to
> being thread safe?
Hello Chen, this class does contain state and is allowed to contain state as
long as it is thread safe. So I think the current brief comment is enough.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23986#discussion_r2068530664
