On Thu, 24 Apr 2025 09:21:03 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 370 commits: > > - Revert unwanted changes > - Merge branch 'master' into implement-jep502 > - Address comments > - Replace 'contents' with 'result' in the docs > - Rephrase happens-before clause > - Replace 'content' with 'contents' and doc updates > - Merge branch 'master' into implement-jep502 > - Remove section on fun/coll sync > - Reformat docs > - Fix failing test (exception message) > - ... and 360 more: https://git.openjdk.org/jdk/compare/290d24d1...bcc022fe src/java.base/share/classes/java/util/ImmutableCollections.java line 888: > 886: private static final class StableReverseOrderListView<E> extends > ReverseOrderListView.Rand<E> { > 887: > 888: public StableReverseOrderListView(List<E> base) { public? src/java.base/share/classes/java/util/ReverseOrderListView.java line 300: > 298: public String toString() { > 299: Iterator<E> it = iterator(); > 300: if (! it.hasNext()) Suggestion: if (!it.hasNext()) src/java.base/share/classes/java/util/ReverseOrderListView.java line 308: > 306: E e = it.next(); > 307: sb.append(e == this ? "(this Collection)" : e); > 308: if (! it.hasNext()) Suggestion: if (!it.hasNext()) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2057967620 PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2057958943 PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2057960785