On Wed, 9 Apr 2025 15:34:25 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Core reflection's generic signature parsing uses an ancient library with >> outdated visitor pattern on a tree model and contains unnecessary >> boilerplates. This is a duplication of ClassFile API's signature model. We >> should just move to ClassFile API, which is more throughoutly tested as well. >> >> To ensure compatibility, new tests are added to ensure consistent behavior >> when encountering malformed signatures or signatures with missing types. The >> reflective objects have been preserved and the only change is that lazy >> expansion now happens from CF objects, to reduce compatibility risks. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains five commits: > > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/new-generic-info > - Improve BytecodeDescriptor error message > - Years, test facelift > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/new-generic-info > - 8333377: Migrate Generic Signature parsing to ClassFile API src/java.base/share/classes/sun/reflect/generics/info/ClassGenericInfo.java line 1: > 1: /* Given that this basically rewrites most of `sun.reflect.generics.*`, I feel like it might be better to just move these new files to `jdk.internal.reflect.generics.*`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19281#discussion_r2056085416
