On Wed, 16 Apr 2025 16:26:41 GMT, Joe Wang <jo...@openjdk.org> wrote:

>> Streamline the extension function control in the XPath API by relying solely 
>> on 
>> [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html),
>>  which provides a secure and developer-defined mechanism. Remove the feature 
>> FEATURE_SECURE_PROCESSING and jdk.xml.enableExtensionFunctions from the 
>> decision path that are redundant with regard to XPath's Extension Functions.
>> 
>> Note the comment in JAXPExtensionsProvider, starting at  "JAXP 1.3 spec says 
>> When ...", was not accurate. Refer to the spec: 
>> https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/XMLConstants.html#FEATURE_SECURE_PROCESSING,
>>  FSP does not have specific requirement for the XPath functions.
>> 
>> Tests:
>>     Tier1 - 3 passed with regard to this change. There were unrelated/known 
>> failures (e.g. bug8329757).
>>     JCK passed except the previously reported issue (JCK-7322355).
>
> Joe Wang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains five additional commits since 
> the last revision:
> 
>  - Merge branch 'master' into JDK-8354084
>  - update javadoc for the jdk.xml.enableExtensionFunctions property
>  - rewind resource files, leave them to L10n resource files update
>  - add copyright and docs
>  - 8354084: Streamline XPath API's extension function control

look fine.  Thanks

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24605#pullrequestreview-2773211383

Reply via email to