On Thu, 7 Nov 2024 10:51:15 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 15 commits: >> >> - Add JEP number, update copyright headers >> - Merge branch 'master' into JDK-8342486 >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8342486 >> - Sync up from loom repo >> - Merge branch 'master' into JDK-8342486 >> - Merge branch 'master' into JDK-8342486 >> - Fix link >> - Merge branch 'master' into JDK-8342486 >> - Sync up impl/tests form loom repo >> - ... and 5 more: https://git.openjdk.org/jdk/compare/3090e218...418bc3d3 > > src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java > line 337: > >> 335: * <a >> href="{@docRoot}/java.base/java/util/concurrent/package-summary.html#MemoryVisibility"> >> 336: * <i>happen-before</i></a> any actions taken by that subtask, which in >> turn >> 337: * <i>happen-before</i> the subtask result is {@linkplain Subtask#get() >> retrieved}. > > Chen has suggested that this be expanded to specify a HB between onComplete > and join. Viktor and I have discussed extending the existing text to deal > with subtask outcome that "contributes" to the scope result but did not agree > wording (note that this is a pre-existing short-coming in the spec, not a new > issue). I'm not sure where we are on this topic. Clearly there's an edge between the pre-join and post-join phases. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21934#discussion_r2044516724
