On Mon, 14 Apr 2025 13:51:30 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> update to minimise code changes
>
> src/java.base/share/classes/java/net/Proxy.java line 102:
>
>> 100: formatMsg("type " + type + " is not compatible with
>> address %s",
>> 101: filterNetInfo(sa.toString())
>> 102: .replaceWith("type " +
>> sa.getClass().toString())));
>
> You will have to guard against sa == null here
The `replaceWith()` call is actually not needed at all. I will remove it
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23929#discussion_r2044273655
