On Thu, 10 Apr 2025 06:34:24 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 307 commits: > > - Fix typo > - Merge branch 'master' into implement-jep502 > - Fix typo in return type > - Change double to int > - Fix typo > - Update examples > - Remove parantheses > - Only use partial functions > - Fix typo > - Add note an partial and total functions > - ... and 297 more: https://git.openjdk.org/jdk/compare/250eb743...9c7b48b7 src/java.base/share/classes/java/lang/StableValue.java line 90: > 88: * If {@code getLogger()} is called from several threads, several > instances of > 89: * {@code Logger} might be created. However, the content can only be set > at most once > 90: * meaning one "winner" is picked among the many loggers. Suggestion: * meaning that the first writer wins. src/java.base/share/classes/java/lang/StableValue.java line 92: > 90: * meaning one "winner" is picked among the many loggers. > 91: * <p> > 92: * To guarantee that, even under races, only one instance of {@code > Logger} is ever Suggestion: * In order to guarantee that, even under races, only one instance of {@code Logger} is ever ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2036961021 PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2036962326
