On Thu, 13 Mar 2025 15:22:43 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 246 commits: > > - Merge branch 'master' into implement-jep502 > - Clean up exception messages and fix comments > - Rename field > - Rename method and fix comment > - Rework reenterant logic > - Use acquire semantics for reading rather than volatile semantics > - Add missing null check > - Simplify handling of sentinel, wrap, and unwrap > - Fix JavaDoc issues > - Fix members in StableEnumFunction > - ... and 236 more: https://git.openjdk.org/jdk/compare/4e51a8c9...d6e1573f I'm surprised to see `@ForceInline` in the offset query functions in `Unsafe`. Those are not on any fast path I'm aware of. What use case does this annotation address? If none, consider deleting; it will be a future maintenance puzzle. Or at least document in a comment why a slow path function needs such an annotation. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23972#issuecomment-2727063749
