On Wed, 5 Feb 2025 12:03:36 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix JdbExprTest > > src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 143: > >> 141: * @return If both characters are numbers, return d0 * 10 + d1, >> otherwise return -1 >> 142: */ >> 143: @ForceInline > > Can we leave this out? From the doc: "This annotation must be used sparingly." > I tried without and on M1 performance does not seem to be affected. Again, can we avoid `@ForceInline`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22919#discussion_r1943315049
