On Fri, 3 Jan 2025 14:39:53 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Skip the test (throw `jtreg.SkippedException`) if the volume that owns the >> test's work directory doesn't support DOS file names. > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Add missing `@library /test/lib` and update copyright year Sorry, I was not clear in my question. What I mean is what will happen if following command run manually by user from terminal without DOS file names support: `java.lang.AssertionError: Expected [0]. Actual [1]: Check command [C:\\testuser\\output_openjdk25_dev_dbgU_ntamd64\\testee-vm\\bin\\jpackage.exe --input .\\test.a5cf5d26\\input --dest .\\test.a5cf5d26\\output --name WinLongPathTest --type app-image --main-jar hello.jar --main-class Hello --win-console --temp .\\test.a5cf5d26\\long-path\\aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\\ccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc -J-Djlink.debug=true --verbose](18) exited with 0 code` Based on call stack in JBS jpackage will fail, but it is not clear why and what error message from jpackage is displayed in such case. If error message is not user friendly I think we should make it user friendly and explain reason for failure. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22896#issuecomment-2569842074
