On Wed, 4 Dec 2024 16:40:17 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Alexey Semenyuk has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8334319
>> - 8334319: Missing keys in jpackage resource bundle
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties
> line 61:
>
>> 59: error.short-path-conv-fail=Failed to get short version of "{0}" path
>> 60: error.missing-service-installer='service-installer.exe' service
>> installer not found in the resource directory
>> 61: error.missing-service-installer.advice=Add 'service-installer.exe'
>> service installer to the resource directory
>
> Same here.
Should I revert changes in `WinResources_*.properties` files?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22533#discussion_r1869926258
