On Wed, 4 Dec 2024 05:14:55 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> - Add missing resource keys to Windows property files;
>> - Fix the code to throw `ConfigException` if the service installer
>> executable is required but not available instead of throwing the exception
>> only when it is not found in the resource directory;
>> - Fix `JPackageStringBundle.getFormattedString()` that should not use a
>> resource property string as a format for `MessageFormat.format()` if there
>> are no arguments for formatting. `MessageFormat.format()` interprets
>> characters in the format string, e.g., it removes single quotes.
>> - Add tests.
>
> Alexey Semenyuk has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains two additional
> commits since the last revision:
>
> - Merge branch 'master' into JDK-8334319
> - 8334319: Missing keys in jpackage resource bundle
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties
line 61:
> 59: error.short-path-conv-fail=Failed to get short version of "{0}" path
> 60: error.missing-service-installer='service-installer.exe' service installer
> not found in the resource directory
> 61: error.missing-service-installer.advice=Add 'service-installer.exe'
> service installer to the resource directory
No need to substitute English resouces into localized ones. L10n process will
automatically detect the diff, and translate them accordingly.
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties
line 61:
> 59: error.short-path-conv-fail=Failed to get short version of "{0}" path
> 60: error.missing-service-installer='service-installer.exe' service installer
> not found in the resource directory
> 61: error.missing-service-installer.advice=Add 'service-installer.exe'
> service installer to the resource directory
Same here.
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties
line 61:
> 59: error.short-path-conv-fail=Failed to get short version of "{0}" path
> 60: error.missing-service-installer='service-installer.exe' service installer
> not found in the resource directory
> 61: error.missing-service-installer.advice=Add 'service-installer.exe'
> service installer to the resource directory
Same here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22533#discussion_r1869915792
PR Review Comment: https://git.openjdk.org/jdk/pull/22533#discussion_r1869916101
PR Review Comment: https://git.openjdk.org/jdk/pull/22533#discussion_r1869916412
