> Can I please get a review for this PR that add tests to verify the value of > `@since` tags to the Tools area modules. The test is described in this > [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). > This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442. > > The benefit from this is helping API authors and reviewer validate the > accuracy of `@since` in their source code (and subsequently, in the generated > documentation). And lessen the burden on Reviewers. > > The test has been added for `java.base` and a few other modules and has > helped catch some bugs before they make it to the JDK. > > Notes: > - I have also added an `@since` tag that was missing. > - You will notice there is no test for the `jdk.jfr` module, it will be added > in a future PR because it requires special handling. (JFR used to be a > commercial feature and this requires special handling to be added for it in > the test) > > TIA
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: Revert "add a missing \@since tag to RecordingStream.onMetadata" This reverts commit 091fb28320e2cd3471bfb5640202dbf4f04afbbe. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/21982/files - new: https://git.openjdk.org/jdk/pull/21982/files/091fb283..7858f99b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21982&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21982&range=03-04 Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/21982.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21982/head:pull/21982 PR: https://git.openjdk.org/jdk/pull/21982