On Tue, 5 Nov 2024 14:15:24 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add checks of exception messages > > test/jdk/java/foreign/TestLinker.java line 188: > >> 186: assertEquals(e.getMessage(), >> 187: "The padding layout x2 was preceded by another >> padding layout x1 in [b1x1x2i4]"); >> 188: } > > Doesn't `assertThrows` return the exception instance? (which could be used to > check the message as well). Unfortunately not in testng. In JUnit 5 it does. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21041#discussion_r1829447400
