> Can I please get a review of this change which does a tiny cleanup in the > macosx specific code in `java_props_macosx.c`? > > As noted in https://bugs.openjdk.org/browse/JDK-8342647 the > `setOSNameAndVersion` function used to dynamically call > `NSProcessInfo.operatingSystemVersion` because that property wasn't > (statically) available until macosx 10.10 version. Since that version this > property has been available even in the latest macosx versions > https://developer.apple.com/documentation/foundation/nsprocessinfo/1410906-operatingsystemversion, > so it's now possible to statically reference it in the code. > > The change in this PR replaces the use of `NSInvocation` with the static > reference to this property. No new tests have been added. Existing tier1, > tier2 and tier3 tests with this change have all passed.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: minor code comment update ------------- Changes: - all: https://git.openjdk.org/jdk/pull/21595/files - new: https://git.openjdk.org/jdk/pull/21595/files/a824d059..7c402540 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21595&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21595&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/21595.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21595/head:pull/21595 PR: https://git.openjdk.org/jdk/pull/21595
