On Fri, 11 Oct 2024 16:21:30 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null >> checks across the ClassFile API. This is an updated version of #20556 that >> minimizes impact on our implementation code. >> >> Notes: >> 1. There's one change in `MethodHandleProxies` to explicitly use platform >> class loader instead of `null` for boot class loader. Tests work fine. >> 2. The null check test uses the same set of classes as CorpusTest to make it >> suitable for tier 1. >> 3. The test is not comprehensive; currently it is permissive toward IAE, >> because sometimes some substitution arguments are invalid, especially >> primitive ClassDesc or Opcode with wrong types. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > asotona review remarks Since this PR no longer adds a test, the issue should probably be renamed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21458#issuecomment-2408158068
