On Wed, 9 Oct 2024 18:05:55 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - assertThrows instead of expectedExceptions >> - ordered jtreg tags according recommendation in >> https://openjdk.org/jtreg/tag-spec.html#ORDER > > Wiki pages such as > https://wiki.openjdk.org/display/csr/Fields+of+a+CSR+Request are good > starting points for CSRs. > > CSR review will look at CSRs listed at > https://bugs.openjdk.org/secure/Dashboard.jspa?selectPageId=17313. To > finalize a CSR for review, you should set your fix version; I fixed that when > I marked myself as a reviewer on the CSR. > > Also note that the CSR lead might be unavailable the next few days, so the > review will wait for a bit. Meanwhile, it's good for other experienced > reviewers like Alan to review the CSR too. @liach Just to make it clear: Thumbs up for "current code *is* more understandible" or thumbs up for "undo last commit"? 🤔 ------------- PR Comment: https://git.openjdk.org/jdk/pull/21371#issuecomment-2408097139
