On Tue, 1 Oct 2024 16:20:02 GMT, Chen Liang <li...@openjdk.org> wrote:

>> src/java.base/share/classes/java/util/zip/ZipError.java line 31:
>> 
>>> 29:  * Signals that an unrecoverable error has occurred.
>>> 30:  *
>>> 31:  * @deprecated ZipError is no longer used and is obsolete.
>> 
>> I agree ZipError should be deprecated. Can the JBS issue and PR title be 
>> updated as they still have "for removal".
>
> Isn't this deprecation intended for removal? Or do you mean this 
> `@deprecated` tag should note that this class will be removed in a future 
> release?

Alan,

This is probably better discussed in the CSR. Please see the latest comments 
there.

I think we're still waiting for concensus/conclusion in the CSR on whether the 
deprecation of the class itself should be for removal or not.

Joe suggested that the class be marked deprecated, not for removal, and that 
the constructor be marked deprecated, for removal. He asked for input on this 
suggestion, which unfortunately took me a while. 

The latest comment from me and @liach made a case for deprecating the class for 
removal. We are waiting for input from Joe on this.

Once the CSR concludes on a solution, I'll of course update the CSR and PR 
accordingly.

Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20642#discussion_r1783169355

Reply via email to