On Tue, 10 Sep 2024 11:06:28 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337143: Remove loading libnet from Inet6AddressImpl; delete commented out
>> #include in Windows IOUtil.c
>
> src/java.base/share/classes/sun/nio/ch/IOUtil.java line 575:
>
>> 573: * Used to trigger loading of native libraries
>> 574: */
>> 575: public static void load() { }
>
> do we still need this method?
Yes, it still needs to be called in a few places, e.g., for classes whose
native component needs the `fdval()` and `handleval()` functions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1752651246
