On Tue, 10 Sep 2024 09:56:26 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8337143: Remove loading libnet from Inet6AddressImpl; delete commented out >> #include in Windows IOUtil.c > > make/modules/java.base/Lib.gmk line 81: > >> 79: libjava/nio/ch \ >> 80: libnio/ch \ >> 81: libnio/fs \ > > libnio/fs is gone on all platforms other than aix; is this still necessary? We can't add extra header dirs on a per-platform basis, so if it is needed for AIX it will need to remain here. Otoh, the only "cost" is an additional `-I <dir>` argument to the compiler, so it's not too bad. But if we can remove it, we should, of course. > make/modules/java.base/lib/CoreLibraries.gmk line 71: > >> 69: -framework Foundation \ >> 70: -framework SystemConfiguration, \ >> 71: LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib >> version.lib ws2_32.lib, \ > > Can the libs added here be removed from libnio dependencies now? mswsock.lib > appears to be unused by libnio, not sure about other platforms. I believe this question has already been answered [here](https://github.com/openjdk/jdk/pull/20317/files#r1707599113). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1751967809 PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1751975461
