On Tue, 27 Aug 2024 15:38:24 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>>> I don't think the costs for two address comparisons matter, not with the >>> comparatively few deallocations that happen (few hundreds or few thousand). >>> If deallocate is hot, we are using metaspace wrong. >> >> MethodData does a lot of deallocations from metaspace because it's allocated >> racily. It might be using Metaspace wrong. > >> > I don't think the costs for two address comparisons matter, not with the >> > comparatively few deallocations that happen (few hundreds or few >> > thousand). If deallocate is hot, we are using metaspace wrong. >> >> MethodData does a lot of deallocations from metaspace because it's allocated >> racily. It might be using Metaspace wrong. > > I think that should be okay. This should still be an exception. I have never > seen that many deallocations happening in customer cases. > @tstuefe Do you have more comments on this PR? Sorry, I was swamped the past days. I'll take a look tomorrow. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19157#issuecomment-2326867932
