On Tue, 27 Aug 2024 15:51:24 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Please review this PR which suggests to deprecate the unused class >> `java.util.zip.ZipError` for removal. >> >> The class has been unsed by OpenJDK since the ZIP API was rewritten from >> native to Java in JDK 9. >> >> I opted to not explain the reason for the deprecation in detail, but instead >> simply point to `ZipException` as an alternative. Should more explanation be >> desired, I could prepend that with a note saying that the class is unused >> since JDK 9. >> >> A CSR for this API update has been drafted, I'll update the Specification >> section there once we reach a concensus on the deprecation note in this PR. >> >> This deprecation was initially suggested here: >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-June/125720.html > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Extend the deprecation note to mention that the error became obsolete in > JDK 9 and to mention that code may be updated to catch the super class > InternalError The updated deprecation specification looks good to me. I will review the CSR when you update it. Needs Lance or another engineer in the area to confirm too. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20642#pullrequestreview-2264064055
