On Tue, 13 Aug 2024 18:13:30 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove the last OMWorld references >> - Rename omworldtable_work to object_monitor_table_work > > src/hotspot/share/runtime/lightweightSynchronizer.cpp line 1194: > >> 1192: // Recursive lock successful. >> 1193: current->inc_held_monitor_count(); >> 1194: // Clears object monitor cache, because ? > > What does this comment mean? I probably meant to write something about how x86_32 still uses the cache, so it is important that the CacheSetter clears it here. I'll remove the comment and add one on the CacheSetter explaining why it is necessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1716414912
