On Wed, 22 May 2024 18:22:24 GMT, Sandhya Viswanathan
<sviswanat...@openjdk.org> wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> un-helper-ize preload_needle_helper; try fix for macos build
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 101:
>
>> 99: if (isU) { \
>> 100: __ blsrl(tmp, mask); \
>> 101: __ blsrl(mask, tmp); \
>
> We could do this as
> __ blsrl(mask, mask); \
> __ blsrl(mask, mask); \
> Thereby removing the need for tmp.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1614127638
