On Tue, 7 May 2024 22:50:18 GMT, Doug Lea <d...@openjdk.org> wrote:

> This set of changes address causes of poor utilization with small numbers of 
> cores due to overly aggressive contention avoidance. A number of further 
> adjustments were needed to still avoid most contention effects in deployments 
> with large numbers of cores

src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 962:

> 960:      * minimum allowed timeout value.
> 961:      */
> 962:     static final long TIMEOUT_SLOP = 20L;

Might be worth spelling out the temporal unit used here.

src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2101:

> 2099:      * Awaits signal or termination.
> 2100:      *
> 2101:      * @param w the worker

Suggestion:

     * @param w the work queue

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19131#discussion_r1597522226
PR Review Comment: https://git.openjdk.org/jdk/pull/19131#discussion_r1597522098

Reply via email to