On Mon, 6 May 2024 20:48:05 GMT, Chen Liang <li...@openjdk.org> wrote:
> A peek into TypeKind during the research for #19105 reveals that TypeKind has > a few issues: > 1. Name mismatch for `newarraycode` and `fromNewArrayCode`: Renamed both to > use "newarray code" > 2. `fromDescriptor` can throw IOOBE if the input string is empty: changed to > throw IAE and added tests. > 3. `from(Class)` can be slow due to descriptor computation: added benchmark, > will share result in next comment (as it may change with code changes). > > The first 2 changes involves API changes, and a CSR has been created. > Requesting @asotona for a review. This pull request has now been integrated. Changeset: 784b8fce Author: Chen Liang <li...@openjdk.org> Committer: Claes Redestad <redes...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/784b8fce7a1b05209a8db168c8d2f86484a1a817 Stats: 183 lines in 5 files changed: 167 ins; 0 del; 16 mod 8331744: java.lang.classfile.TypeKind improvements Reviewed-by: asotona, redestad ------------- PR: https://git.openjdk.org/jdk/pull/19109
