On Mon, 5 Feb 2024 21:31:36 GMT, Vladimir Yaroslavskiy <d...@openjdk.org> wrote:
>> Hi Vladimir (@iaroslavski), >> >> Please see the data below. All tests were run after putting the DPQS code in >> java.util package and recompiling the JDK for each case. >> >> <html xmlns:v="urn:schemas-microsoft-com:vml" >> xmlns:o="urn:schemas-microsoft-com:office:office" >> xmlns:x="urn:schemas-microsoft-com:office:excel" >> xmlns="http://www.w3.org/TR/REC-html40";> >> >> <head> >> >> <meta name=ProgId content=Excel.Sheet> >> <meta name=Generator content="Microsoft Excel 15"> >> <link id=Main-File rel=Main-File >> href="file:///C:/Users/sparasa/AppData/Local/Temp/msohtmlclip1/01/clip.htm"> >> <link rel=File-List >> href="file:///C:/Users/sparasa/AppData/Local/Temp/msohtmlclip1/01/clip_filelist.xml"> >> >> >> >> </head> >> >> <body link="#0563C1" vlink="#954F72"> >> >> >> Benchmark (us/op) | (builder) | (size) | Stock JDK | a15 | r20p | r20s >> -- | -- | -- | -- | -- | -- | -- >> ArraysSort.Int.testParallelSort | RANDOM | 600 | 2.24 | 2.201 | 2.423 | 2.389 >> ArraysSort.Int.testParallelSort | RANDOM | 9000 | 35.318 | 35.961 | 79.028 | >> 83.774 >> ArraysSort.Int.testParallelSort | RANDOM | 20000 | 118.729 | 120.872 | >> 134.829 | 138.349 >> ArraysSort.Int.testParallelSort | RANDOM | 400000 | 822.676 | 822.44 | >> 1200.858 | 872.264 >> ArraysSort.Int.testParallelSort | RANDOM | 3000000 | 5864.514 | 5948.82 | >> 8800.391 | 6020.616 >> ArraysSort.Int.testParallelSort | REPEATED | 600 | 0.924 | 0.936 | 0.752 | >> 0.733 >> ArraysSort.Int.testParallelSort | REPEATED | 9000 | 9.896 | 9.317 | 31.409 | >> 24.896 >> ArraysSort.Int.testParallelSort | REPEATED | 20000 | 58.265 | 42.189 | 40.92 >> | 40.101 >> ArraysSort.Int.testParallelSort | REPEATED | 400000 | 256.952 | 253.217 | >> 236.568 | 239.163 >> ArraysSort.Int.testParallelSort | REPEATED | 3000000 | 2844.107 | 2851.088 | >> 2752.939 | 3040.423 >> ArraysSort.Int.testParallelSort | STAGGER | 600 | 2.245 | 2.296 | 2.15 | >> 2.219 >> ArraysSort.Int.testParallelSort | STAGGER | 9000 | 29.278 | 29.119 | 28.288 >> | 28.141 >> ArraysSort.Int.testParallelSort | STAGGER | 20000 | 50.129 | 50.442 | 49.746 >> | 49.686 >> ArraysSort.Int.testParallelSort | STAGGER | 400000 | 463.309 | 413.619 | >> 418.077 | 407.519 >> ArraysSort.Int.testParallelSort | STAGGER | 3000000 | 3687.198 | 4363.242 | >> 3732.777 | 3769.898 >> ArraysSort.Int.testParallelSort | SHUFFLE | 600 | 1.715 | 1.698 | 2.799 | >> 2.733 >> ArraysSort.Int.testParallelSort | SHUFFLE | 9000 | 27.69 | 27.183 | 32.883 | >> 32.373 >> ArraysSort.Int.testParallelSort | SHUFFLE | 20000 | 62.067 | 60.987 | 63.281 >> | 52.89 >> ArraysSort.Int.testParalle... > > Hello Vamsi (@vamsi-parasa), > > Many thanks for the results! Now we can see that intrinsics are applied in > all cases, > but there are big differences between the same code. > > For example, > parallelSort REPEATED 20000: 58.265(Stock JDK) and 42.189(a15) with speedup > x1.38 > parallelSort STAGGER 3000000: 3687.198(Stock JDK) 4363.242(a15) with speedup > x0.85 > > Case a15 is the current source code from JDK, but in one benchmarking it is > faster, > in other benchmarking it is slower (~15-30%). > > Other strange behaviour with new sorting: r20p and r20s have the same code for > sequential sorting (no radix sort at all), but we can see that on case works > much slower > > sort STAGGER 3000000: 34406.74(r20p) and 10467.03(r20s) - 3.3 times slower, > whereas other sizes show more or less equal values. > > Vamsi (@vamsi-parasa), > Could you please run benchmarking of 5 cases with **updated** test class > **ArraysSortNew**? > https://github.com/iaroslavski/sorting/blob/master/radixsort/ArraysSortNew.java > > Put the DPQS code in java.util package and recompiling the JDK for each case > as you > did before, but run new **ArraysSortNew**. > > Find the sources there: > > https://github.com/iaroslavski/sorting/blob/master/radixsort/ArraysSortNew.java > https://github.com/iaroslavski/sorting/blob/master/radixsort/DualPivotQuicksort_jdk.java > https://github.com/iaroslavski/sorting/blob/master/radixsort/DualPivotQuicksort_r20p.java > https://github.com/iaroslavski/sorting/blob/master/radixsort/DualPivotQuicksort_r20s.java > https://github.com/iaroslavski/sorting/blob/master/radixsort/DualPivotQuicksort_r25p.java > https://github.com/iaroslavski/sorting/blob/master/radixsort/DualPivotQuicksort_r25s.java > > Thank you, > Vladimir Hi Vladimir (@iaroslavski), The new ArraysSortNew.Java has compilation issues: error: DualPivotQuicksort is not public in java.util; cannot be accessed from outside package java.util.DualPivotQuicksort.sort(b, PARALLELISM, 0, b.length); Have you run into this issue? Thanks, Vamsi ------------- PR Comment: https://git.openjdk.org/jdk/pull/13568#issuecomment-1933243711
