On Fri, 22 Dec 2023 20:19:17 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> This is a regression caused by the fix to >> [JDK-8317979](https://bugs.openjdk.org/browse/JDK-8317979), where the >> parsing of TZDB files was incorrect. With this fix, `TimeZoneNames_en.java` >> which is generated during the build time has the following diffs from the >> previous (incorrect) one: >> >> --- >> master/build/macosx-aarch64/support/gensrc/java.base/sun/util/resources/cldr/TimeZoneNames_en.java >> 2023-12-18 10:28:57 >> +++ >> tz/build/macosx-aarch64/support/gensrc/java.base/sun/util/resources/cldr/TimeZoneNames_en.java >> 2023-12-22 10:09:13 >> @@ -304,11 +304,11 @@ >> }; >> final String[] Azores = new String[] { >> "Azores Standard Time", >> - "HMT", >> + "", >> "Azores Summer Time", >> - "HMT", >> + "", >> "Azores Time", >> - "HMT", >> + "", >> }; >> final String[] Bhutan = new String[] { >> "Bhutan Time", >> @@ -968,11 +968,11 @@ >> }; >> final String[] Africa_Central = new String[] { >> "Central Africa Time", >> - "SAST", >> - "", >> - "SAST", >> + "CAT", >> "", >> - "SAST", >> + "CAT", >> + "", >> + "CAT", >> }; >> final String[] Africa_Eastern = new String[] { >> "East Africa Time", >> @@ -1016,11 +1016,11 @@ >> }; >> final String[] Europe_Western = new String[] { >> "Western European Standard Time", >> - "FMT", >> - "Western European Summer Time", >> - "FMT", >> + "WET", >> + "Western European Summer Time", >> + "WEST", >> "Western European Time", >> - "FMT", >> + "WET", >> }; >> final String[] Mexico_Pacific = new String[] { >> "Mexican Pacific Standard Time", >> @@ -1152,11 +1152,11 @@ >> }; >> final String[] Australia_Western = new String[] { >> "Australian Western Standard Time", >> - "", >> + "AWST", >> "Australian Western Daylight Time", >> - "", >> + "AWDT", >> "Western Australia Time", >> - "", >> + "AWT", >> }; >> final String[] Greenland_Eastern =... > > make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 2: > >> 1: /* >> 2: * Copyright (c) 2012, 2024, Oracle and/or its affiliates. All rights >> reserved. > > 2024 already? ;-) Thanks, Joe. Not planning to integrate it this year, so. There's a Japanese proverb, saying demons would laugh if speaking of the next year, though 🙂 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17187#discussion_r1435356191
