On Tue, 5 Dec 2023 22:01:04 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Create RandomBigIntegers.java
>>   
>>   Create a benchmark to measure the performance of BigInteger(int, Random) 
>> constructor implementation.
>
> So, item 1 is a non-issue and item 2 is not likely a problem in practice. 
> What, if anything, will be done about item 3?

> @bplb Maybe an assertion at the end of `randomBits(int, Random)` method, or a 
> test class.

@fabioromano1 A test class would be better as then we would be able to catch 
any problems during routine testing. Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16817#issuecomment-1843266956

Reply via email to