On Thu, 26 Oct 2023 18:11:01 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Explicitly handle UpcallStub allocation failures by terminating. We >> currently might try to use the returned `nullptr` which would fail sooner or >> later. This patch just makes the termination explicit. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: > > Throw OOME for allocation failures I've also removed the test that tries to trigger an OOME when allocating downcall stubs. It seems not really possible to isolate that particular code path (unless a direct whitebox API is added maybe, but that also kinda defeats the purpose of testing), leading to a flaky test. I've left the test for upcall stubs, as that seems to work well enough (but, might need to drop that as well). ------------- PR Comment: https://git.openjdk.org/jdk/pull/16311#issuecomment-1782629405
