On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> I submitted PR #15555 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i also make performance faster. >> Please review and don't hesitate to critique my approach and patch. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision: > > Use StringConcatFactory.makeConcatWithConstants In the jvm args for your benchmark, add `-XX:StartFlightRecording=filename=<your recording name>.jfr` When you have that flag, you just need one run, as subsequent runs will override the existing jfr recording. If you have jfr for both a slow and a fast run, you can use VisualVM to see their CPU time differences. It's just JDK's builtin profiler. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16006#issuecomment-1767454580
