On Thu, 21 Sep 2023 13:43:30 GMT, Adam Sotona <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix logical bug with char array filling
>
> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java
> line 236:
>
>> 234: private void inflate() {
>> 235: int singleBytes = JLA.countPositives(rawBytes, offset,
>> rawLen);
>> 236: int hash = ArraysSupport.vectorizedHashCode(rawBytes,
>> offset, singleBytes, 0, ArraysSupport.T_BOOLEAN);
>
> We should keep in mind that this code is on lambdas bootstrap critical path.
> Any foreign code may involve lambdas or method references and cause dead end
> in lambdas initialization after JDK-8294960.
This is safe: these two functions are already used in String itself (see
StringLatin1) which is definitely loaded and initialized before Classfile API
and its implementations are.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15837#discussion_r1333101060
