On Tue, 29 Aug 2023 11:58:14 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simulate
>> loading of an external LoggerFinder service while also having other threads
>> poke System.getLogger during this framework initialization.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments from Daniel. Further test clean up
Only minor comment updates. Otherwise LGTM!
test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java
line 46:
> 44:
> 45: /**
> 46: * This test triggers recursion by calling `System.getLogger` in the
> class init
Suggestion:
* This test triggers recursion by calling `System.getLogger` in the class
init and constructor
test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/RecursiveLoadingTest.java
line 41:
> 39:
> 40: /**
> 41: * This test triggers recursion by calling `System.getLogger` in the
> class init
Suggestion:
* This test triggers recursion by calling `System.getLogger` in the class
init and constructor
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15404#pullrequestreview-1600360266
PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1308784213
PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1308785012
