On Tue, 27 Jun 2023 18:29:45 GMT, Tim Prinzing <[email protected]> wrote:
>> src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 408:
>>
>>> 406: @Override
>>> 407: public int read(ByteBuffer buf) throws IOException {
>>> 408: if (!SocketReadEvent.enabled()) {
>>
>> The read/write with sun.nio.ch.SocketInputStream and SocketOutputStream does
>> not go through SC.read/write so I think SocketAdaptor read/write will need
>> attention, maybe a future PR as there are other code paths that aren't
>> covered in this PR.
>
> I've created https://bugs.openjdk.org/browse/JDK-8310978 to drive the future
> PR to support the missing code paths
Thanks, it's a reminder that the existing SocketXXX events are incomplete
and/or not much I/O done with the socket adaptors.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14342#discussion_r1301143720
