On Mon, 31 Jul 2023 18:38:30 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Fixes a bug showing up after >> [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are >> capturing groups outside the match. > > Raffaello Giulietti has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Merged with mainline. > - Merge branch 'master' into 8312976 > - Refactored recent tests as JUnit parametrized test. > - Added a test with negatvie lookbehind. > - Added test with a lookahead containing a back reference. > - 8312976: MatchResult produces StringIndexOutOfBoundsException for groups > outside match This looks okay. I think its would be useful to get another reviewer to also look over this in case there is any other issues. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15053#pullrequestreview-1559778227
