On Fri, 14 Jul 2023 18:25:45 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Going over some old issues and found this RFE, posting without any tests or >> a CSR first to get some feedback on the overall API. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Clarify docs based on review feedback. Looks good to me. test/jdk/java/lang/Class/ForPrimitiveName.java line 80: > 78: "java.lang.Float", > 79: "java.lang.Double", > 80: "java.lang.Void"); Maybe worth adding the descriptor name for primitive types in the negative test cases serving as examples. ------------- Marked as reviewed by mchung (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14743#pullrequestreview-1530897451 PR Review Comment: https://git.openjdk.org/jdk/pull/14743#discussion_r1264088315
