On Thu, 11 May 2023 18:34:45 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Several Handlers class use monitors to synchronize when formatting / >> publishing LogRecords. >> When logging within a VirtualThread, holding this monitor can cause the >> carrier thread to be pinned. >> Handlers could use jdk.internal.misc.InternalLock, in a similar way to some >> java.io classes (such as PrintStream) to avoid pinning the carrier thread. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Use ReentrantLock directly Marked as reviewed by jpai (Reviewer). The latest changes to use `ReentrantLock` instead of `InternalLock` looks fine to me. ------------- PR Review: https://git.openjdk.org/jdk/pull/13832#pullrequestreview-1424455046 PR Comment: https://git.openjdk.org/jdk/pull/13832#issuecomment-1545699479
