On Thu, 6 Apr 2023 01:45:37 GMT, Xiaohong Gong <xg...@openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> style
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorSlice.java line 466:
>
>> 464: @IR(counts = {IRNode.VECTOR_SLICE, "17"})
>> 465: static void testB128(byte[][] dst, byte[] src1, byte[] src2) {
>> 466: var species = ByteVector.SPECIES_128;
>
> Suggest to define the species as a "`private static final`" field of this
> test class. It may make the intrinsification fail if the species is not a
> constant to the compiler.
This local is final and is loaded from a `static final` field so it should be
equivalent to referring to `ByteVector.SPECIES_128` directly
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12909#discussion_r1186024843
