On Mon, 27 Mar 2023 18:37:12 GMT, Jim Laskey <[email protected]> wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill
test/jdk/java/lang/StringBuilder/StringBuilderRepeat.java line 180:
> 178:
> 179: try {
> 180: sb.repeat(0x10FFFF + 1, -1);
Should these tests that test invalid codepoints use a valid repeat count as to
verify the IAE is correctly thrown for the out-of-bound codepoint? Tests where
both params are illegal are fine, too, of course.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12728#discussion_r1150396671
