On Tue, 7 Feb 2023 20:38:40 GMT, Matthew Donovan <d...@openjdk.org> wrote:
>> Removed SSLSocketParametersTest.sh script (which just called a Java file) >> and configured the java code to run directly with jtreg > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: > > added exceptions for cases 4 and 5 test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 211: > 209: throw exc; > 210: } > 211: } Having exception handling in the run() method and also in this switch statement is quite confusing. It obscures the fact that these cases (4 and 5) don't call run() at all. It would be good to find a structure that makes it clear that some test cases are for exceptions that occur at ServerFactory creation time and other exceptions occur when an actual socket connection is attempted. ------------- PR: https://git.openjdk.org/jdk/pull/11910
